Fixes for various export related issues #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jest Coverage
|
|
@ianroberts @davidwilby can either one of you have a look at this before we merge it in? |
ianroberts
force-pushed
the
various-export-issues
branch
from
72f848d
to
901bbf7
Compare
ianroberts
force-pushed
the
various-export-issues
branch
from
901bbf7
to
e289227
Compare
ianroberts
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
All LGTM now - I've rebased on latest dev, combining your changes with mine from #399, and I'm happy to merge this now.
| @@ -1047,7 +1052,7 @@ def get_doc_annotation_dict(self, json_format="raw", anonymize=True): | |||
| ("aborted", Annotation.ABORTED), | |||
| ]: | |||
| teamware_status[key] = [ | |||
| annotation.user.id if anonymize else annotation.user.username | |||
| f"{settings.ANONYMIZATION_PREFIX}{annotation.user.id}" if anonymize else annotation.user.username | |||
There was a problem hiding this comment.
I've updated the teamware_status to use the same anonymized names as everything else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namefield and keys insideannotation_setssettings.ANONYMIZATION_PREFIX), defaults toannotatorfeaturesfield if exporting as GATE formattest_export_gateto check for thisfeaturesfield for each annotation now directly has content of the annotation instead of being nested in alabelfieldcheck_raw_gate_annotation_formattingto check for thisannotation_setsfield. New annotations should be appended to this field rather than overwritten. #348annotation_setsfield while for CSV it'sannotationsfieldcheck_raw_gate_annotation_formattingandtest_export_csvto check for this behaviour